Skip to content

Conversation

WaffleLapkin
Copy link
Member

r? @compiler-errors
Previous PR: #104721

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 29, 2022
@jyn514
Copy link
Member

jyn514 commented Nov 29, 2022

@bors delegate=WaffleLapkin

(Not sure if you wanted a review from Michael too)

@bors
Copy link
Collaborator

bors commented Nov 29, 2022

✌️ @WaffleLapkin can now approve this pull request

@compiler-errors
Copy link
Member

r=me after committing nit (either via the button on github or amending ur commit, i dont care)

suggestion from a friend!! 🐸

Co-authored-by: Michael Goulet <[email protected]>
@WaffleLapkin
Copy link
Member Author

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Nov 29, 2022

📌 Commit 1b4012e has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2022
…iaskrgr

Rollup of 14 pull requests

Successful merges:

 - rust-lang#103876 (type alias impl trait: add tests showing that hidden type only outlives lifetimes that occur in bounds)
 - rust-lang#104427 (Explain why `rematch_impl` fails to be infallible)
 - rust-lang#104436 (Add slice to the stack allocated string comment)
 - rust-lang#104523 (Don't use periods in target names)
 - rust-lang#104627 (Print all features with --print target-features)
 - rust-lang#104911 (Make inferred_outlives_crate return Clause)
 - rust-lang#105002 (Add `PathBuf::as_mut_os_string` and `Path::as_mut_os_str`)
 - rust-lang#105023 (Statics used in reachable function's inline asm are reachable)
 - rust-lang#105045 (`rustc_ast_{passes,pretty}`: remove `ref` patterns)
 - rust-lang#105049 (Hermit: Minor build fixes)
 - rust-lang#105051 (Replace a macro with a function)
 - rust-lang#105062 (rustdoc: use shorthand background for rustdoc toggle CSS)
 - rust-lang#105066 (move `candidate_from_obligation` out of assembly)
 - rust-lang#105068 (Run patchelf also on rust-analyzer-proc-macro-srv.)

Failed merges:

 - rust-lang#105050 (Remove useless borrows and derefs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b596d6b into rust-lang:master Nov 30, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 30, 2022
@WaffleLapkin WaffleLapkin deleted the deref-ahhhh~ branch December 2, 2022 16:20
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 7, 2022
…TaKO8Ki

Remove more `ref` patterns from the compiler

Previous PR: rust-lang#105045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants